commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <>
Subject [jira] [Commented] (DBCP-477) Documentation out of date and confusing
Date Tue, 01 Aug 2017 00:58:00 GMT


Gary Gregory commented on DBCP-477:

Thank you for your report.

Would you mind providing a PR ( or patch to fix this?

Thank you!

> Documentation out of date and confusing
> ---------------------------------------
>                 Key: DBCP-477
>                 URL:
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Steve Cohen
>            Priority: Minor
> The DBCP package description page ([])
is referred to from the Overview page
> as containing important information on usage of the package.
> The following sample code is provided there:
> {noformat}
> GenericObjectPool connectionPool = new GenericObjectPool(null);
> ConnectionFactory connectionFactory = new DriverManagerConnectionFactory("jdbc:some:connect:string",
"username", "password");
> PoolableConnectionFactory poolableConnectionFactory = new PoolableConnectionFactory(connectionFactory,connectionPool,null,null,false,true);
> PoolingDataSource dataSource = new PoolingDataSource(connectionPool);
> {noformat}
> This is out of date:  the six argument constructor for PoolableConnectionFactory has
been removed.  Additionally, even if the correct constructor is used, nothing connects the
PortableConnectionFactory created on the third line with the pool.
> There is a much better sample at [;a=blob;f=doc/;h=2a12c74898930b9623223db1597b8a8052a6f1df;hb=56deeaf5ccbbee5081dbcce374685f4399d71bd5]
> However this should be accessible from any of several "examples" links on the site, all
of which are broken.

This message was sent by Atlassian JIRA

View raw message