commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Richter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-1426) Add constructor with Double[] argument to DescriptiveStatistics
Date Fri, 04 Aug 2017 16:23:00 GMT

    [ https://issues.apache.org/jira/browse/MATH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114581#comment-16114581
] 

Karl Richter commented on MATH-1426:
------------------------------------

bq. So, in this issue's case, using a randomly populated array is just a convenience: the
code could be checked with a "manually" chosen set of values; hence, we can choose any seed
(and keep that one forever).

Interesting, thanks for the detailed explanation. I imitated the code of other tests as suggested.

bq. For "Commons Math" main code (in the "main" directory), only the API part would become
a dependency.
I also think that "slf4j-api" is a safe choice (but this must be decided on the ML).

One discussion is http://markmail.org/message/pf46s7775bt37swk for reference. That's tricky
because of the wide range of interests. SLF4J is the most often declared dependency in github.com
projects<ref>https://en.wikipedia.org/wiki/SLF4J</ref>.

bq. I'm no maven expert; please raise this issue on the "dev" ML (use different posts for
different subjects).

Done. The title is `[MATH] Enforce run of checkstyle-maven-plugin in validate instead of site
phase`

bq. I didn't figure out what you mean by wrong tabulation
bq. For example, I'd think that in most of the code, the alignment would be (to be viewed
with a fixed-width font...):

I took over your example, the rest will be covered by checkstyle enforcement.

> Add constructor with Double[] argument to DescriptiveStatistics
> ---------------------------------------------------------------
>
>                 Key: MATH-1426
>                 URL: https://issues.apache.org/jira/browse/MATH-1426
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Karl Richter
>             Fix For: 4.0
>
>         Attachments: 0001-fixed-javadoc-of-constructors-in-DescriptiveStatisti.patch,
0002-added-constructor-with-Double-argument-to-Descriptiv.patch
>
>
> It'd be nice to have a `Double[]` constructor in `DescriptiveStatistics`.
> The patch is available at https://github.com/apache/commons-math/pull/54 in form of a
PR as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message