commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-98) Remove isDelimiter() and use HashSets for delimiter check
Date Tue, 01 Aug 2017 15:04:00 GMT

    [ https://issues.apache.org/jira/browse/TEXT-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109049#comment-16109049
] 

ASF GitHub Bot commented on TEXT-98:
------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/57
  
    
    [![Coverage Status](https://coveralls.io/builds/12640859/badge)](https://coveralls.io/builds/12640859)
    
    Coverage decreased (-0.2%) to 98.021% when pulling **fb6d5935451397c561bd52cf1d483975f83b2c7b
on arunvinudss:TEXT-98** into **998764ebe38113eb51e6850058ca01936625dd92 on apache:master**.



> Remove isDelimiter() and use HashSets for delimiter check
> ---------------------------------------------------------
>
>                 Key: TEXT-98
>                 URL: https://issues.apache.org/jira/browse/TEXT-98
>             Project: Commons Text
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Arun Vinud 
>            Priority: Minor
>             Fix For: 1.2
>
>
> The current implementation of *capitalize*, *uncapitalize* and *initials* in *WordUtils*
calls *isDelimiter* for every character and/or codepoint and isDelimiter loops through the
array of delimiters to check for the  occurrence. This is a bit inefficient and results in
O(nk) complexity and it can be reduced to O( n )[if n>k] or O( k ) [if k>n].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message