Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C82A200CBA for ; Mon, 3 Jul 2017 16:26:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3A852160C00; Mon, 3 Jul 2017 14:26:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 833CB160BEC for ; Mon, 3 Jul 2017 16:26:06 +0200 (CEST) Received: (qmail 98679 invoked by uid 500); 3 Jul 2017 14:26:05 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 98658 invoked by uid 99); 3 Jul 2017 14:26:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jul 2017 14:26:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3B72FC023D for ; Mon, 3 Jul 2017 14:26:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nnT40L4fIARN for ; Mon, 3 Jul 2017 14:26:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 46DE55FD84 for ; Mon, 3 Jul 2017 14:26:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 89E96E0BCB for ; Mon, 3 Jul 2017 14:26:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BA8DD245FC for ; Mon, 3 Jul 2017 14:26:01 +0000 (UTC) Date: Mon, 3 Jul 2017 14:26:01 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NUMBERS-46) ContinuedFraction: "maxIterations" argument MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 03 Jul 2017 14:26:07 -0000 [ https://issues.apache.org/jira/browse/NUMBERS-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072518#comment-16072518 ] Gilles commented on NUMBERS-46: ------------------------------- Please review the modifications: commit 5a2f9d1492f0a9679c64a91d4e536b936fd815e4 > ContinuedFraction: "maxIterations" argument > ------------------------------------------- > > Key: NUMBERS-46 > URL: https://issues.apache.org/jira/browse/NUMBERS-46 > Project: Commons Numbers > Issue Type: Bug > Reporter: Gilles > Assignee: Gilles > Priority: Minor > Fix For: 1.0 > > > In class {{o.a.c.numbers.fraction.ContinuedFraction}}, method {{evaluate}} is declared as > {code} > public double evaluate(double x, double epsilon, int maxIterations) > {code} > Calling > {code} > cf.evaluate(x, eps, 1) > {code} > will raise an exception: > {noformat} > org.apache.commons.numbers.fraction.FractionException: maximal count (1) exceeded > {noformat} > At first sight, the check > {code} > if (n >= maxIterations) { > {code} > should rather be > {code} > if (n > maxIterations) { > {code} > However, it would also seem that the loop counter is wrong: > {code} > while (n < maxIterations) { > {code} > since setting {{maxIterations}} to 1 will in effect execute _zero_ iteration... -- This message was sent by Atlassian JIRA (v6.4.14#64029)