Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8BDCA200CBA for ; Mon, 3 Jul 2017 17:51:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8992B160BEC; Mon, 3 Jul 2017 15:51:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CFBE8160BE4 for ; Mon, 3 Jul 2017 17:51:03 +0200 (CEST) Received: (qmail 8088 invoked by uid 500); 3 Jul 2017 15:51:02 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 8077 invoked by uid 99); 3 Jul 2017 15:51:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jul 2017 15:51:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 816FFC14D0 for ; Mon, 3 Jul 2017 15:51:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id vDZkxtmJ6Tv6 for ; Mon, 3 Jul 2017 15:51:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0A86E5FDAD for ; Mon, 3 Jul 2017 15:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4FACEE0877 for ; Mon, 3 Jul 2017 15:51:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0F88E245F5 for ; Mon, 3 Jul 2017 15:51:00 +0000 (UTC) Date: Mon, 3 Jul 2017 15:51:00 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (NET-638) Telnet subnegotiations hard-limited to 512 bytes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 03 Jul 2017 15:51:04 -0000 [ https://issues.apache.org/jira/browse/NET-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-638. ---------------------- Resolution: Fixed Fix Version/s: 3.7 Thanks for the PR; applied: URL: http://svn.apache.org/viewvc?rev=1800691&view=rev Log: NET-638 - Telnet subnegotiations hard-limited to 512 bytes - allow override Modified: commons/proper/net/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc?rev=1800694&view=rev Log: NET-638 - Telnet subnegotiations hard-limited to 512 bytes - allow override Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetClient.java commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java > Telnet subnegotiations hard-limited to 512 bytes > ------------------------------------------------ > > Key: NET-638 > URL: https://issues.apache.org/jira/browse/NET-638 > Project: Commons Net > Issue Type: Improvement > Components: Telnet > Affects Versions: 3.6 > Reporter: Daniel Leong > Fix For: 3.7 > > Original Estimate: 1h > Remaining Estimate: 1h > > Currently using Commons.net's Telnet client for connecting to MUD/MUSH servers, and some servers use subnegotiation for sending out-of-band data with more than the hard-coded 512 bytes that TelnetInputStream limits it to. It looks like it would be straightforward to add an (optional) int constructor parameter to TelnetClient that passes it to a similar, new TelnetInputStream constructor parameter. > I've got a workaround using a bunch of reflection, but it'd be nice to not need that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)