Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 5 Jul 2017 15:39:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13079299.1497297286000.174646.1499269140221@Atlassian.JIRA>
In-Reply-To: <JIRA.13079299.1497297286000@Atlassian.JIRA>
References: <JIRA.13079299.1497297286000@Atlassian.JIRA> <JIRA.13079299.1497297286220@jira-lw-us.apache.org>
Subject: [jira] [Commented] (COMPRESS-410) Remove   ZipEncoding
 implementations introduced to work around problems in jdk 1.4
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 05 Jul 2017 15:39:06 -0000


    [ https://issues.apache.org/jira/browse/COMPRESS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074958#comment-16074958 ] 

ASF GitHub Bot commented on COMPRESS-410:
-----------------------------------------

Github user bodewig commented on the issue:

    https://github.com/apache/commons-compress/pull/37
  
    Thanks a lot Simon,
    
    Please take a look at fde6670 - I've only performed some minor changes that I didn't feel like hackling you for. Things that may be a tiny bit more than just cosmetics:
    
    * I'm not sure why you went for the literal string `UTF-8` rather than the constant and `isUTF8` method in `ZipEncodingHelper`, I've changed that (kinda) back
    * I've removed the `assert` from `NioZipEncoding.encode`


> Remove   ZipEncoding implementations introduced to work around problems in jdk 1.4
> ----------------------------------------------------------------------------------
>
>                 Key: COMPRESS-410
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-410
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>    Affects Versions: 1.14
>            Reporter: Simon Spero
>            Priority: Minor
>             Fix For: 1.15
>
>
> There are several implementations of ZipEncoding that are provided to work around missing character sets  in JDK 1.4. 
> Since commons-compress requires JDK7 or later, this code is no longer needed. As the classes are package private, they can be removed without affecting the API. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)