commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbduncan <...@git.apache.org>
Subject [GitHub] commons-lang pull request #276: IntelliJ IDEA refactorings
Date Tue, 11 Jul 2017 12:13:41 GMT
GitHub user jbduncan opened a pull request:

    https://github.com/apache/commons-lang/pull/276

    IntelliJ IDEA refactorings

    Implement a number of changes which reduce warnings reported by IntelliJ IDEA on its default
settings (as discussed on the mailing list).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbduncan/commons-lang intellij-idea-refactorings

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #276
    
----
commit 5dfb56d7efd5cda396c256ba941a02769f98889b
Author: Jonathan Bluett-Duncan <jbluettduncan@gmail.com>
Date:   2017-07-09T21:03:06Z

    Simplify `expression == false` usages to `!expression`
    
    This eliminates some warnings reported by IntelliJ IDEA when running
    with default settings.
    
    CharRange, StrBuilder and StrSubstitutor were considered as targets for
    this refactoring, but they were left alone because they are either
    deprecated or scheduled for removal.

commit b5260f809940b0626d986889ca3bcbc5ffc68cad
Author: Jonathan Bluett-Duncan <jbluettduncan@gmail.com>
Date:   2017-07-09T21:20:39Z

    Simplify boolean expression in StringUtils
    
    This eliminates a warning reported by IntelliJ IDEA when running with
    default settings.
    
    There is no need to check that `startIndex != -1` because `startIndex`
    is always initialized to 0 and is never mutated afterwards.

commit 37776f5f9c2e692a71aa3bd742a9138685385c61
Author: Jonathan Bluett-Duncan <jbluettduncan@gmail.com>
Date:   2017-07-09T21:42:27Z

    Remove redundant return variables
    
    This eliminates some warnings reported by IntelliJ IDEA when running
    with default settings.

commit 8900c3225f0187cb380066e4527f7d46528c05f6
Author: Jonathan Bluett-Duncan <jbluettduncan@gmail.com>
Date:   2017-07-09T21:52:06Z

    Replace 'for' loops with 'foreach' loops in LocaleUtils
    
    This eliminates a couple of warnings reported by IntelliJ IDEA when
    running with default settings.

commit c38416dab40b93c6b6b8a2a77c5860e2d1b779b5
Author: Jonathan Bluett-Duncan <jbluettduncan@gmail.com>
Date:   2017-07-09T22:16:06Z

    Replace manual iterations with bulk `Collections.addAll` calls
    
    This eliminates a couple of warnings reported by IntelliJ IDEA when
    running with default settings.

commit 464ef50cae892e98192065f36482765c02cdcadf
Author: Jonathan Bluett-Duncan <jbluettduncan@gmail.com>
Date:   2017-07-09T22:31:33Z

    Replace String concatenation with chained `StringBuffer.append()` call
    
    This eliminates a warning reported by IntelliJ IDEA when running with
    default settings.

commit 856327acf5c34642ba10264045bf1ffdfa2deb9f
Author: Jonathan Bluett-Duncan <jbluettduncan@gmail.com>
Date:   2017-07-09T23:03:47Z

    Replace simple `StringBuilder` usages with String concatenations
    
    This eliminates some warnings reported by IntelliJ IDEA when running
    with default settings.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message