commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (NUMBERS-38) No unit tests for "LanczosApproximation" class
Date Wed, 05 Jul 2017 13:20:02 GMT

     [ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gilles resolved NUMBERS-38.
---------------------------
    Resolution: Done

In commit 91090df9869177582c327c6c7159e981a90efd70, I've added the three trivial checks which
you had initially proposed. I think that given checks in higher-level unit tests ({{Gamma}}
etc.), there is no need to have a complicated setup (random generator) like in your latest
PR.

The comments have compounded several issues; please do not hesitate to open specific reports
that handle one issue at at time. Thanks for your help!


> No unit tests for "LanczosApproximation" class
> ----------------------------------------------
>
>                 Key: NUMBERS-38
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-38
>             Project: Commons Numbers
>          Issue Type: Test
>            Reporter: Gilles
>              Labels: unit-test
>             Fix For: 1.0
>
>         Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package {{o.a.c.numbers.gamma}} in module
{{commons-numbers-gamma}}) function is not checked by unit tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message