commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Eckenfels (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-386) FileUtils.doCopyFile uses different methods to check the file sizes
Date Thu, 06 Jul 2017 02:35:00 GMT

    [ https://issues.apache.org/jira/browse/IO-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075820#comment-16075820
] 

Bernd Eckenfels commented on IO-386:
------------------------------------

After discussion in IO-544 I also wonder if the transferFrom returning 0 case does not need
a few retries to avoid the length difference exception


> FileUtils.doCopyFile uses different methods to check the file sizes
> -------------------------------------------------------------------
>
>                 Key: IO-386
>                 URL: https://issues.apache.org/jira/browse/IO-386
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>
> FileUtils.doCopyFile uses FileChannel.size() to measure the input file length at the
start, and File.length() to compare the lengths at the end.
> This is inconsistent.
> If there is a good reason for this it should be documented, otherwise it should probably
use the same method for all the checks.
> [Note: is FileChannel.size() accurate if the file has not been flushed?]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message