Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5331E200CB9 for ; Sun, 18 Jun 2017 03:47:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 51219160BEA; Sun, 18 Jun 2017 01:47:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 97314160BD2 for ; Sun, 18 Jun 2017 03:47:04 +0200 (CEST) Received: (qmail 25753 invoked by uid 500); 18 Jun 2017 01:47:03 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 25742 invoked by uid 99); 18 Jun 2017 01:47:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jun 2017 01:47:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 46DAAC6725 for ; Sun, 18 Jun 2017 01:47:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 462vBQE_oUNY for ; Sun, 18 Jun 2017 01:47:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 109645F2A9 for ; Sun, 18 Jun 2017 01:47:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4C858E02C8 for ; Sun, 18 Jun 2017 01:47:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0BEB023FFE for ; Sun, 18 Jun 2017 01:47:00 +0000 (UTC) Date: Sun, 18 Jun 2017 01:47:00 +0000 (UTC) From: "Simon Spero (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (COMPRESS-411) TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 18 Jun 2017 01:47:05 -0000 [ https://issues.apache.org/jira/browse/COMPRESS-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053045#comment-16053045 ] Simon Spero commented on COMPRESS-411: -------------------------------------- I have a full set of fixes (apart from checking when decoding that for base256 values the most significant bytes for lengths > 8 octets are just sign extension (i.e. 0x080 + 0x00{p} or 0xff + 0xff{p}. The changes are mixed in with a bunch of other changes to TarUtils that are needed for direct encoding/decoding to ByteBuffers. > TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary > --------------------------------------------------------------------------- > > Key: COMPRESS-411 > URL: https://issues.apache.org/jira/browse/COMPRESS-411 > Project: Commons Compress > Issue Type: Bug > Components: Archivers > Affects Versions: 1.14 > Reporter: Simon Spero > Priority: Minor > Fix For: 1.15 > > > if the length < 9, formatLongBinary is executed, then overwritten by the results of formatBigIntegerBinary. > If the results are not ignored, a unit test would fail. > Also, do the binary hacks need to support negative numbers? -- This message was sent by Atlassian JIRA (v6.4.14#64029)