Return-Path: <issues-return-62027-archive-asf-public=cust-asf.ponee.io@commons.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B7952200CA4
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  7 Jun 2017 08:45:54 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id B621C160BD0; Wed,  7 Jun 2017 06:45:54 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2F89C160BB6
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  7 Jun 2017 08:45:54 +0200 (CEST)
Received: (qmail 57222 invoked by uid 500); 7 Jun 2017 06:45:53 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 57205 invoked by uid 99); 7 Jun 2017 06:45:52 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2017 06:45:52 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B8DBDE000B; Wed,  7 Jun 2017 06:45:52 +0000 (UTC)
From: kinow <git@git.apache.org>
To: issues@commons.apache.org
Reply-To: issues@commons.apache.org
References: <git-pr-269-commons-lang@git.apache.org>
In-Reply-To: <git-pr-269-commons-lang@git.apache.org>
Subject: [GitHub] commons-lang pull request #269: LANG-1337: Fix test failures in IBM JDK 8 fo...
Content-Type: text/plain
Message-Id: <20170607064552.B8DBDE000B@git1-us-west.apache.org>
Date: Wed,  7 Jun 2017 06:45:52 +0000 (UTC)
archived-at: Wed, 07 Jun 2017 06:45:54 -0000

Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/269#discussion_r120545692
  
    --- Diff: src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java ---
    @@ -316,7 +316,7 @@ public void testReflectionHierarchyArrayList() {
             // representation different for IBM JDK 1.6.0, LANG-727
             assumeFalse("IBM Corporation".equals(SystemUtils.JAVA_VENDOR) && "1.6".equals(SystemUtils.JAVA_SPECIFICATION_VERSION));
             assumeFalse("Oracle Corporation".equals(SystemUtils.JAVA_VENDOR) && "1.6".compareTo(SystemUtils.JAVA_SPECIFICATION_VERSION) < 0);
    -        final List<Object> list = new ArrayList<>();
    +        final List<Object> list = new ArrayList<>(10);
    --- End diff --
    
    Fair enough on the magic number. I'd thought about that, then noticed a few other tests with numbers. But one broken window doesn't mean I can break another one :-) fixing in another commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---