Return-Path: <issues-return-61991-archive-asf-public=cust-asf.ponee.io@commons.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 39219200C8C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue,  6 Jun 2017 16:57:56 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 37EA8160BC6; Tue,  6 Jun 2017 14:57:56 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id A499C160BC3
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  6 Jun 2017 16:57:55 +0200 (CEST)
Received: (qmail 17632 invoked by uid 500); 6 Jun 2017 14:57:54 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 17620 invoked by uid 99); 6 Jun 2017 14:57:54 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 14:57:54 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 50761DF9FD; Tue,  6 Jun 2017 14:57:54 +0000 (UTC)
From: sebbASF <git@git.apache.org>
To: issues@commons.apache.org
Reply-To: issues@commons.apache.org
References: <git-pr-269-commons-lang@git.apache.org>
In-Reply-To: <git-pr-269-commons-lang@git.apache.org>
Subject: [GitHub] commons-lang pull request #269: LANG-1337: Fix test failures in IBM JDK 8 fo...
Content-Type: text/plain
Message-Id: <20170606145754.50761DF9FD@git1-us-west.apache.org>
Date: Tue,  6 Jun 2017 14:57:54 +0000 (UTC)
archived-at: Tue, 06 Jun 2017 14:57:56 -0000

Github user sebbASF commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/269#discussion_r120385458
  
    --- Diff: src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java ---
    @@ -316,7 +316,7 @@ public void testReflectionHierarchyArrayList() {
             // representation different for IBM JDK 1.6.0, LANG-727
             assumeFalse("IBM Corporation".equals(SystemUtils.JAVA_VENDOR) && "1.6".equals(SystemUtils.JAVA_SPECIFICATION_VERSION));
             assumeFalse("Oracle Corporation".equals(SystemUtils.JAVA_VENDOR) && "1.6".compareTo(SystemUtils.JAVA_SPECIFICATION_VERSION) < 0);
    -        final List<Object> list = new ArrayList<>();
    +        final List<Object> list = new ArrayList<>(10);
    --- End diff --
    
    I think that needs a comment.
    Is the magic number 10 significant?
    If so, what determines the value?
    Could it ever change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---