commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-93) RandomStringGenerator accepts a list of valid characters
Date Sat, 24 Jun 2017 14:11:00 GMT

    [ https://issues.apache.org/jira/browse/TEXT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062008#comment-16062008
] 

ASF GitHub Bot commented on TEXT-93:
------------------------------------

Github user ameyjadiye commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/54#discussion_r123877950
  
    --- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java ---
    @@ -76,23 +78,29 @@
         private final TextRandomProvider random;
     
         /**
    +     * The source of provided charachters.
    +     */
    +    private final List<Character> characterList;
    +
    +    /**
          * Constructs the generator.
    -     *
    -     * @param minimumCodePoint
    +     *  @param minimumCodePoint
          *            smallest allowed code point (inclusive)
          * @param maximumCodePoint
          *            largest allowed code point (inclusive)
          * @param inclusivePredicates
    -     *            filters for code points
    -     * @param random
    -     *            source of randomness
    + *            filters for code points
    --- End diff --
    
    yeah, seems like IntelliJ did this unknowingly, fixed it!


> RandomStringGenerator accepts a list of valid characters
> --------------------------------------------------------
>
>                 Key: TEXT-93
>                 URL: https://issues.apache.org/jira/browse/TEXT-93
>             Project: Commons Text
>          Issue Type: Wish
>            Reporter: Wilson MacGyver
>
>  implement a "selectFrom" feature:
>   RandomStringGenerator gen = new RandomStringGenerator.Builder()
>     .selectFrom(charArray)
>     .build();
> so we can pass a list of valid characters



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message