commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
Date Wed, 21 Jun 2017 12:17:00 GMT

    [ https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057388#comment-16057388
] 

Bruno P. Kinoshita edited comment on JEXL-227 at 6/21/17 12:16 PM:
-------------------------------------------------------------------

Felt tempted to quickly fix and commit. But then realized there are two methods with 3.0:
#getEngineVersion and #getLanguageVersion.

Not sure if we should update both, or one and not the other, or update only with major releases...
Will wait to see if someone else knows (maybe [~henrib] or [~ebourg]?) more about these methods,
and then maybe we could override the javadoc (or complement, and use that inheritDoc tag too
if necessary) saying what to do / why.

Cheers
Bruno


was (Author: kinow):
Felt tempted to quickly fix and commit. But then realized there are two methods with 3.0:
#getEngineVersion and #getLanguageVersion.

Not sure if we should update both, or one and not the other, or update only with major releases...
Will wait to see if someone else knows (maybe [~henrib] ?) more about these methods, and then
maybe we could override the javadoc (or complement, and use that inheritDoc tag too if necessary)
saying what to do / why.

Cheers
Bruno

> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of
reporting
> -----------------------------------------------------------------------------------------------
>
>                 Key: JEXL-227
>                 URL: https://issues.apache.org/jira/browse/JEXL-227
>             Project: Commons JEXL
>          Issue Type: Bug
>    Affects Versions: 3.1
>            Reporter: Dmitri Blinov
>            Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine version in
3.1
> {code}
>     public String getEngineVersion() {
>         return "3.0"; // ensure this is updated if function changes are made to this
class
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message