commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (TEXT-90) Add CharacterPredicates for ASCII letters (uppercase/lowercase) and arabic numerals
Date Thu, 15 Jun 2017 19:36:00 GMT


ASF GitHub Bot commented on TEXT-90:

Github user PascalSchumacher commented on a diff in the pull request:
    --- Diff: src/test/java/org/apache/commons/text/ ---
    @@ -44,4 +44,77 @@ public void testDigits() {
    +    @Test
    +    public void testArabicNumerals() {
    --- End diff --
    I personally do not like junit parametrized tests because every test method has to be
in its own class and you have to a lot of boiler plate. For parametrized test I use
    Theories can be nice for testing methods with multiple parameters, although in my opinion
well chosen parameter combinations are often enough. I think theories are a bit lacking compared
to "real" property based testing like quick-check (no test data generation, no failure shrinking).
For java is the best option I'm aware of, but
it has been requiring java 8 for years.

> Add CharacterPredicates for ASCII letters (uppercase/lowercase) and arabic numerals
> -----------------------------------------------------------------------------------
>                 Key: TEXT-90
>                 URL:
>             Project: Commons Text
>          Issue Type: New Feature
>            Reporter: Pascal Schumacher
>            Assignee: Pascal Schumacher
>             Fix For: 1.2
> I tried to migrate a project from RandomStringUtils to RandomStringGenerator today, but
I found it hard to replace methods like RandomStringUtils#randomAlphanumeric and RandomStringUtils#randomAlphabetic.
> I believe it would ease migration from RandomStringUtils to RandomStringGenerator if
CharacterPrecidates would offer more predicates.

This message was sent by Atlassian JIRA

View raw message