commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLI-277) Add generics to TypeHandler
Date Wed, 14 Jun 2017 10:02:00 GMT

    [ https://issues.apache.org/jira/browse/CLI-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048998#comment-16048998
] 

ASF GitHub Bot commented on CLI-277:
------------------------------------

Github user kinow commented on the issue:

    https://github.com/apache/commons-cli/pull/13
  
    +1 code in pull request looks good, tests too. But when I checked out the code to read
it on Eclipse, I thought the class Javadoc a bit confusing.
    
    ```
     * This is a temporary implementation. TypeHandler will handle the
     * pluggableness of OptionTypes and it will direct all of these types
     * of conversion functionalities to ConvertUtils component in Commons
     * already. BeanUtils I think.
    ```
    
    Haven't checked the git log, but after reading it, it sounds like this class is a temporary
solution until another class is ready to be used as a replacement? I wonder if there is a
class in some other component perhaps that we could use and maybe replace it? Or we can just
update this javadoc later.


> Add generics to TypeHandler
> ---------------------------
>
>                 Key: CLI-277
>                 URL: https://issues.apache.org/jira/browse/CLI-277
>             Project: Commons CLI
>          Issue Type: Improvement
>            Reporter: Benedikt Ritter
>            Assignee: Benedikt Ritter
>
> TypeHandler currently works on Object. Since we pass the class class of the return value,
we can add generics. This way we don't need to cast the returned value explicitly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message