commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-410) Remove ZipEncoding implementations introduced to work around problems in jdk 1.4
Date Sat, 17 Jun 2017 00:20:01 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052564#comment-16052564
] 

ASF GitHub Bot commented on COMPRESS-410:
-----------------------------------------

GitHub user sesuncedu opened a pull request:

    https://github.com/apache/commons-compress/pull/36

    COMPRESS-410 Remove Non-NIO character set encoders.

    As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'.
    This behavior is required for compatibility with existing behavior.
    
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-compress/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit 1c9e1d8218ccd102567273eebdfba187ca545fc8
Author: Simon Spero <sesuncedu@gmail.com>
Date:   2017-06-17T00:17:13Z

    COMPRESS-410 Remove Non-NIO character set encoders.
    As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'.
    This behavior is required for compatibility with existing behavior.
    
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>

----


> Remove   ZipEncoding implementations introduced to work around problems in jdk 1.4
> ----------------------------------------------------------------------------------
>
>                 Key: COMPRESS-410
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-410
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>    Affects Versions: 1.14
>            Reporter: Simon Spero
>            Priority: Minor
>
> There are several implementations of ZipEncoding that are provided to work around missing
character sets  in JDK 1.4. 
> Since commons-compress requires JDK7 or later, this code is no longer needed. As the
classes are package private, they can be removed without affecting the API. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message