commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-407) Validate Block and Record Sizes
Date Fri, 23 Jun 2017 00:56:00 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060257#comment-16060257
] 

ASF GitHub Bot commented on COMPRESS-407:
-----------------------------------------

GitHub user sesuncedu opened a pull request:

    https://github.com/apache/commons-compress/pull/42

    COMPRESS-407:  Allow use of invalid record sizes if a system property is set.

    I do not recommend using this approach.  #40 is the preferred solution. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-407-SYSTEM-PROPERTY

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-compress/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit f0c21325faf6f613821a8b542c73ac380f0feb6a
Author: Simon Spero <sesuncedu@gmail.com>
Date:   2017-06-11T22:48:42Z

    COMPRESS-407 Validate Block and Record Sizes
    
    Require block size >=0 that is multiple of 512 bytes.
    Use block size of 512 if one is not given.
    Require record size of 512 bytes. Deprecate constructors taking recordSize as parameter
    
    Modify tests to check for enforcement of record size == 512
    Modify tests to check for correct overall length  for
    different block sizes including PAX default, USTAR default, and unspecified.
    
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>
    
    (cherry picked from commit d754d89)
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>

commit 368cb1b7520f78803772b5eff4b28622432479d8
Author: Simon Spero <sesuncedu@gmail.com>
Date:   2017-06-23T00:50:13Z

    COMPRESS-407 Validate Block sizes. Detect invalid record sizes. Allow them through if
a
    system property is set.
    
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>

----


> Validate Block and Record Sizes
> -------------------------------
>
>                 Key: COMPRESS-407
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-407
>             Project: Commons Compress
>          Issue Type: Sub-task
>          Components: Archivers
>            Reporter: Simon Spero
>
> Reject record sizes not equal to 512 bytes; require block sizes to be multiples of 512
bytes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message