commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-399) OSGI package versions are overly pessimistic, except when they're overly optimisic
Date Fri, 02 Jun 2017 17:30:08 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035088#comment-16035088
] 

ASF GitHub Bot commented on COMPRESS-399:
-----------------------------------------

GitHub user sesuncedu opened a pull request:

    https://github.com/apache/commons-compress/pull/26

    COMPRESS-399 OSGI package versions are overly pessimistic, except when they're overly
optimisic

    - Add packageinfo files for per-package version settings.
      - Initialize to 1.14
      - Copy packageinfo files in resource phase.
    
    - Use latest bundle plugin.
      - Remove  headers from generate manifest.
      - Pretty-print the manifest.
      - Add bundle:baseline to the verify phase
      - Add bundle:baseline-report to the site phase
        - To change the base version from default (i.e. previous release) set comparisonVersion
property
    - Change travis build to use verify instead of test 
    
    Signed-off-by: Simon Spero <sesuncedu@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-399

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-compress/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----

----


> OSGI package versions are overly pessimistic, except when they're overly optimisic 
> -----------------------------------------------------------------------------------
>
>                 Key: COMPRESS-399
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-399
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.14
>            Reporter: Simon Spero
>            Priority: Minor
>             Fix For: 1.15
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The OSGI versions in the current distributions are not being correctly generated.  OSGI
relies on package version numbers following semantic version properly for correct resolution.
 
> Current version numbers have been generated from the maven version. This has lead to
new minor version increases for packages that have no API changed; it has also concealed 
 major (breaking) changes to several packages since 1.0.
> I have created two branches that address the issue.
> Both add the bundle:baseline goal to the verify phase of the build. 
> The also both have packageinfo files added to every package, containing the package version.
These are picked up by the bundle manifest generator, and are used if no explicit version
is given in the "Export-Package" command. 
> Both branches bump the major version number for packages with any minor changes to 2.0.0.
 This makes the bundle correct, but does not fix improper import declarations made by users
of earlier bundles.   
> One branch uses the version number  from the oldest version that has no changes when
compared to HEAD, and which has not had any breaking changes since 1.0.0.  This will fail
the build because version numbers should be increasing, and may cause issues if an importing
bundle uses a range that requires an identical, but higher numbered version of the package
> The other branch uses version 1.14.0 for all packages with no major changes. 
> A third alternative, which I didn't add, is to just set all packages be version 1.14.0,
and just bump major versions when required going forward. The bulk of the major changes happened
a good few versions back,  so it's not as bad as it could be. 
> If you have a preferred option, I can create a pull request on Github 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message