commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class
Date Sun, 04 Jun 2017 22:37:04 GMT

    [ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036412#comment-16036412
] 

Gilles commented on NUMBERS-38:
-------------------------------

It is still not clear to me what is the benefit of moving those lines from {{Gamma}} to {{LanczosApproximation}}.
In particular, can you point exactly where the "lanczos approximation" reference algorithm
is defined?

Also, please check what would happen to {{GammaDistribution}} (in package {{o.a.c.math4.distribution}}
of Commons Math).  Thanks.

bq. reference functions given are as whole, I can generate by breaking that code but that's
incorrect.

I can understand the reluctance.

Note that if other unit tests (e.g. those for {{Gamma}}) indirectly cover this class, we could
resolve this issue as "Not a problem" (perhaps just adding a note in {{LanczosApproximationTest}}).


> No unit tests for "LanczosApproximation" class
> ----------------------------------------------
>
>                 Key: NUMBERS-38
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-38
>             Project: Commons Numbers
>          Issue Type: Test
>            Reporter: Gilles
>              Labels: unit-test
>             Fix For: 1.0
>
>         Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package {{o.a.c.numbers.gamma}} in module
{{commons-numbers-gamma}}) function is not checked by unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message