commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Tompkins (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (FILEUPLOAD-189) DiskFileItemFactory use of FileCleaningTracker is documented or coded wrong
Date Tue, 06 Jun 2017 04:50:18 GMT

     [ https://issues.apache.org/jira/browse/FILEUPLOAD-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rob Tompkins closed FILEUPLOAD-189.
-----------------------------------

1.3 released.

> DiskFileItemFactory use of FileCleaningTracker is documented or coded wrong
> ---------------------------------------------------------------------------
>
>                 Key: FILEUPLOAD-189
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-189
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Gregor K
>            Assignee: Simone Tripodi
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: FILEUPLOAD-189.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Regarding latest SVN revision:
> The DiskFileItemFactory documents:
> Temporary files are automatically deleted as soon as they are no longer needed. (More
precisely, when the corresponding instance of {@link java.io.File} is garbage collected.)
> But the code in DiskFileItemFactory.createItem() is doing:
> tracker.track(result.getTempFile(), this);
> Which means the file is cleaned when DiskFileItemFactory is garbage collected.
> This error is propably introduced in Rev 578253 when the code was moved from DiskFileItem
to DiskFileItemFactory, without changing "this" (which was DiskFileItem) and is not DiskFileItemFactory.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message