commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebbASF <>
Subject [GitHub] commons-lang pull request #269: LANG-1337: Fix test failures in IBM JDK 8 fo...
Date Tue, 06 Jun 2017 15:15:13 GMT
Github user sebbASF commented on a diff in the pull request:
    --- Diff: src/test/java/org/apache/commons/lang3/builder/ ---
    @@ -316,7 +316,7 @@ public void testReflectionHierarchyArrayList() {
             // representation different for IBM JDK 1.6.0, LANG-727
             assumeFalse("IBM Corporation".equals(SystemUtils.JAVA_VENDOR) && "1.6".equals(SystemUtils.JAVA_SPECIFICATION_VERSION));
             assumeFalse("Oracle Corporation".equals(SystemUtils.JAVA_VENDOR) && "1.6".compareTo(SystemUtils.JAVA_SPECIFICATION_VERSION)
< 0);
    -        final List<Object> list = new ArrayList<>();
    +        final List<Object> list = new ArrayList<>(10);
    --- End diff --
    If the test fails when the initial size arg is omitted, does that not also affect the
behaviour of the method being tested? i.e. do apps also have to ensure that they specify the
min size when using ToStringBuilder.reflectionToString() ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message