Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 1 May 2017 23:53:04 +0000 (UTC)
From: "Anthony RAYMOND (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13068280.1493682488000.96496.1493682784051@Atlassian.JIRA>
In-Reply-To: <JIRA.13068280.1493682488000@Atlassian.JIRA>
References: <JIRA.13068280.1493682488000@Atlassian.JIRA> <JIRA.13068280.1493682488443@jira-lw-us.apache.org>
Subject: [jira] [Commented] (IO-535) FileAlterationMonitor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 01 May 2017 23:53:07 -0000


    [ https://issues.apache.org/jira/browse/IO-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991817#comment-15991817 ] 

Anthony RAYMOND commented on IO-535:
------------------------------------

GitHub pull request : https://github.com/apache/commons-io/pull/36

> FileAlterationMonitor
> ---------------------
>
>                 Key: IO-535
>                 URL: https://issues.apache.org/jira/browse/IO-535
>             Project: Commons IO
>          Issue Type: Bug
>    Affects Versions: 2.5
>         Environment: Components managed by a DI Framework
>            Reporter: Anthony RAYMOND
>            Priority: Critical
>              Labels: easyfix, patch, performance
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The thread if FileAlterationMonitor wasn't stopped by the `stop(int)` method, which forbid application to shutdown unless all `Thread` are exited (if FileAlterationMonitor is part of a DI managed component).
> This behavior conflict with the method javadoc `@param stopInterval the amount of time in milliseconds to wait for the thread to finish.`
> h5. Simple example to understand
> {code:java}
>     Thread t = new Thread(() -> {
>         try {
>             Thread.sleep(500000);
>         } catch (final InterruptedException e) {
>         }
>     });
>     t.start();
>     t.join(50);
>    // Ok, we reach this point until 500000ms are elapsed, but the thread is still alive.
>    //   because Thread#join(int) does not kill the thread. And the thread remains alive.
> {code}
> {code:java}
>     Thread t = new Thread(() -> {
>         try {
>             Thread.sleep(500000);
>         } catch (final InterruptedException e) {
>         }
>     });
>     t.start();
>     t.join(50);
>     t.interupt();
>    // Thread is exited
> {code}
> In this case, we waited the given time BEFORE exiting the `Thread`, as described in the javadoc, and the `Thread` is now finished and killed.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)