Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D9B53200C8E for ; Wed, 24 May 2017 10:35:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D8863160B9C; Wed, 24 May 2017 08:35:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2AB4F160BB4 for ; Wed, 24 May 2017 10:35:08 +0200 (CEST) Received: (qmail 45925 invoked by uid 500); 24 May 2017 08:35:07 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 45816 invoked by uid 99); 24 May 2017 08:35:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 08:35:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CEB98C0040 for ; Wed, 24 May 2017 08:35:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id i0eGb_xrqRFK for ; Wed, 24 May 2017 08:35:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5DA285F2AB for ; Wed, 24 May 2017 08:35:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A629FE02C8 for ; Wed, 24 May 2017 08:35:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5BDD321B56 for ; Wed, 24 May 2017 08:35:04 +0000 (UTC) Date: Wed, 24 May 2017 08:35:04 +0000 (UTC) From: "Bruno P. Kinoshita (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (COLLECTIONS-596) FileInputStream is not closed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 08:35:09 -0000 [ https://issues.apache.org/jira/browse/COLLECTIONS-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022535#comment-16022535 ] Bruno P. Kinoshita commented on COLLECTIONS-596: ------------------------------------------------ This class has been removed from [collections] when the 4.x version was released. See COLLECTIONS-351 for more. The place where you can find a similar class now is [configuration], probably PropertiesConfiguration. PropertiesConfiguration also contains some calls to a load method passing an InputSteam, which is never closed... but the input stream is passed to the library by the user, so the library in this case should not close it, as users may decide to do something else with it, and are then responsible for properly handling the stream. Marking as Won't Resolve. > FileInputStream is not closed > ----------------------------- > > Key: COLLECTIONS-596 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-596 > Project: Commons Collections > Issue Type: Bug > Affects Versions: 3.2.2 > Reporter: Kaloyan Spiridonov > > In ExtendedProperties class on 602 line the function load is called with input stream. I do not see anywhere stream to be closed. Is there any reason for that? -- This message was sent by Atlassian JIRA (v6.3.15#6346)