commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duncan Jones (JIRA)" <j...@apache.org>
Subject [jira] [Created] (TEXT-84) RandomStringGenerator claims to be immutable, but isn't
Date Thu, 25 May 2017 15:53:04 GMT
Duncan Jones created TEXT-84:
--------------------------------

             Summary: RandomStringGenerator claims to be immutable, but isn't
                 Key: TEXT-84
                 URL: https://issues.apache.org/jira/browse/TEXT-84
             Project: Commons Text
          Issue Type: Bug
    Affects Versions: 1.1
            Reporter: Duncan Jones


{{RandomStringGenerator}} claims to be immutable in the Javadocs, however it accepts a {{TextRandomProvider}}
object through the builder pattern. This object may altered by external code, thus breaking
the immutability claim of our generator.

A possible solution is to adjust the documentation for {{TextRandomProvider}} and require
implementations to be immutable. Alternatively, we can relax the documentation in {{RandomStringGenerator}}
to remove the immutability claim.

I think we will have to do the latter, since the former would forbid callers from supplying
a {{UniformRandomProvider}} instance as suggested in the documentation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message