commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUMBERS-37) Angle class
Date Thu, 11 May 2017 20:25:04 GMT

    [ https://issues.apache.org/jira/browse/NUMBERS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007128#comment-16007128
] 

Gilles commented on NUMBERS-37:
-------------------------------

bq. based \[...\] on radians

It was my first thought, until I figured out that the one function I was porting from "Commons
Math" (i.e. {{MathUtils.normalizeAngle}}) was more efficiently implemented with "turns".
Fortunately, this is an "implementation detail"; so, if "turns" turn out :) to be a bad choice,
we can change it transparently later on.

bq. might we think about including "gons"?

Some things should be left to die. :)
I'm not even sure about "degrees".

bq. prefer core should have very core part of numbers

What should be in it (exhaustively)?

bq. angle is the part of geometry

The {{geometry}} package from "Commons Math" is not likely to become part of "Commons Numbers"
because it's a library unto itself.
{{PlaneAngle}} could be imported by a revamped version of that package, in the same way that
{{Complex}} and {{Quaternion}} will be.

At this point, I'd be careful with what to include in {{PlaneAngle}}. The original idea was
to continue with emptying the "utils" classes, as per the Stian's indirect suggestion in ML
thread about NUMBERS-33).

The other packages you mentioned need refactoring (Ray has started that task), and should
each form their own component.  A first step might be to make them modules within "Commons
Math".


> Angle class
> -----------
>
>                 Key: NUMBERS-37
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-37
>             Project: Commons Numbers
>          Issue Type: New Feature
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>              Labels: api
>             Fix For: 1.0
>
>         Attachments: PlaneAngle.java
>
>
> How about adding (to module {{commons-numbers-core}}) a class representing the "angle"
concept (see attached file)?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message