commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Schultz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CODEC-234) Base32.decode should support lowercase letters
Date Tue, 02 May 2017 19:54:04 GMT

    [ https://issues.apache.org/jira/browse/CODEC-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993605#comment-15993605
] 

Christopher Schultz commented on CODEC-234:
-------------------------------------------

[~garydgregory] Yeah, that's the passage to which I was referring.

It's worth noting that the Hex class is already case-insensitive, as a result of its use of
Character.digit(char,int) method.

I'm okay not supporting 0 (zero) as an alias for O (capital oh) and 1 as an alias for "I"
(capital eye), at least not as a default.

But as it stands, this class behaves in a *very* surprising way for lower-case input.

> Base32.decode should support lowercase letters
> ----------------------------------------------
>
>                 Key: CODEC-234
>                 URL: https://issues.apache.org/jira/browse/CODEC-234
>             Project: Commons Codec
>          Issue Type: Improvement
>    Affects Versions: 1.10
>            Reporter: Christopher Schultz
>            Priority: Minor
>         Attachments: CODEC-234.diff
>
>
> Base32.decode accepts a String input, but any lowercase characters are ignored -- e.g.
Base32.decode("abcd2345") will give a different result than Base32.decode("ABCD1234") with
no errors and a surprise to a developer.
> Accepting any case is desirable, as RFC 4648 makes it clear that case-insensitivity is
a goal for Base32 encoding.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message