commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1164) allow ToStringStyle to omitNulls
Date Mon, 01 May 2017 10:12:05 GMT

    [ https://issues.apache.org/jira/browse/LANG-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990707#comment-15990707
] 

ASF GitHub Bot commented on LANG-1164:
--------------------------------------

Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/209#discussion_r114114198
  
    --- Diff: src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java ---
    @@ -467,6 +472,7 @@ protected void removeLastFieldSeparator(final StringBuffer buffer)
{
          *  for summary info, <code>null</code> for style decides
          */
         public void append(final StringBuffer buffer, final String fieldName, final Object
value, final Boolean fullDetail) {
    +        if (omitNulls && value == null) return;
    --- End diff --
    
    With our current checkstyle checks, this will create an error (error in Checkstyle, not
a build error).


> allow ToStringStyle to omitNulls
> --------------------------------
>
>                 Key: LANG-1164
>                 URL: https://issues.apache.org/jira/browse/LANG-1164
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.builder.*
>            Reporter: Shaun A Elliott
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message