commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-lang issue #209: LANG-1164: allow ToStringStyle to omitNulls
Date Mon, 01 May 2017 10:13:37 GMT
Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/209
  
    +1 lgtm
    
    Looks useful, I've wanted that feature a couple of times when using ReflectionToStringBuilder
in the past.
    
    Merging the code locally, the build passes, all reports look good but Chekstyle.
    
    ```
    org/apache/commons/lang3/builder/ToStringStyle.java
    Severity 	Category 	Rule 	Message 	Line
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	474
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	908
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	1005
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	1067
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	1129
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	1191
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	1253
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	1315
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	1377
     Error 	blocks 	NeedBraces 	'if' construct must use '{}'s. 	1439
    ```
    
    The inlined if fails with our current checkstyle rules. Other than that, all looks good
:-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message