Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F193F200C5C for ; Thu, 20 Apr 2017 22:12:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F03CC160BB0; Thu, 20 Apr 2017 20:12:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 43F75160B90 for ; Thu, 20 Apr 2017 22:12:10 +0200 (CEST) Received: (qmail 19001 invoked by uid 500); 20 Apr 2017 20:12:08 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 18916 invoked by uid 99); 20 Apr 2017 20:12:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Apr 2017 20:12:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A41B71A0048 for ; Thu, 20 Apr 2017 20:12:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DCx0K3dh6eLF for ; Thu, 20 Apr 2017 20:12:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4FAA65FBA0 for ; Thu, 20 Apr 2017 20:12:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C9756E0D40 for ; Thu, 20 Apr 2017 20:12:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 27A9321B57 for ; Thu, 20 Apr 2017 20:12:04 +0000 (UTC) Date: Thu, 20 Apr 2017 20:12:04 +0000 (UTC) From: "Bernd Eckenfels (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IO-531) make it more esay-to-use: org.apache.commons.io.FileUtils.listFiles(File, IOFileFilter, IOFileFilter) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 20 Apr 2017 20:12:11 -0000 [ https://issues.apache.org/jira/browse/IO-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977384#comment-15977384 ] Bernd Eckenfels edited comment on IO-531 at 4/20/17 8:12 PM: ------------------------------------------------------------- The test here implements the (trueFilter, notDir(cvs)) case, but it uses FileFilterUtils.trueFileFilter, should the javadoc use this instead? https://github.com/apache/commons-io/blob/master/src/test/java/org/apache/commons/io/FileUtilsListFilesTestCase.java#L178 was (Author: b.eckenfels): The test here implements the (null, trueFilter) case, but it uses FileFilterUtils.trueFileFilter, should the javadoc use this instead? https://github.com/apache/commons-io/blob/master/src/test/java/org/apache/commons/io/FileUtilsListFilesTestCase.java#L161 > make it more esay-to-use: org.apache.commons.io.FileUtils.listFiles(File, IOFileFilter, IOFileFilter) > ----------------------------------------------------------------------------------------------------- > > Key: IO-531 > URL: https://issues.apache.org/jira/browse/IO-531 > Project: Commons IO > Issue Type: Improvement > Components: Utilities > Affects Versions: 2.5 > Reporter: Hao Liu > Attachments: Commons IOIO-531.pdf > > > when I only want to filter the directories, it should be better to allow me to set the second parameter to null or I have to implement the org.apache.commons.io.filefilter.IOFileFilter interface with nothing functionally task to do. -- This message was sent by Atlassian JIRA (v6.3.15#6346)