Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 20 Apr 2017 21:18:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13059010.1490384624000.11634.1492723084043@Atlassian.JIRA>
In-Reply-To: <JIRA.13059010.1490384624000@Atlassian.JIRA>
References: <JIRA.13059010.1490384624000@Atlassian.JIRA> <JIRA.13059010.1490384624229@jira-lw-us.apache.org>
Subject: [jira] [Commented] (LANG-1317) Add findAnnotation and
 findMethodsWithAnnotation to MethodUtils
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 20 Apr 2017 21:18:10 -0000


    [ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977556#comment-15977556 ] 

ASF GitHub Bot commented on LANG-1317:
--------------------------------------

Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/261#discussion_r112563123
  
    --- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
    @@ -457,6 +457,44 @@ public static String getAbbreviatedName(final String className, final int len) {
         }
     
         /**
    +     * <p>Gets a combination of {@link #getAllSuperclasses}(Class)} and
    +     * {@link #getAllInterfaces}(Class)}, one from superclasses, one
    +     * from interfaces, and so on in a breadth first way.</p>
    +     *
    +     * @param cls  the class to look up, may be {@code null}
    +     * @return the {@code List} of superclasses in order going up from this one
    --- End diff --
    
    This should also mention Interfaces.
    
    Can you add a since tag to this method?
    
    Thanks!


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---------------------------------------------------------------
>
>                 Key: LANG-1317
>                 URL: https://issues.apache.org/jira/browse/LANG-1317
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: Yasser Zamani
>              Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also searches interfaces and super classes while caching results with no memory leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation that also supports non public methods, super class and interface methods, again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be working on it :) 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)