Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B27FA200C5F for ; Sun, 23 Apr 2017 17:13:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B1209160B8E; Sun, 23 Apr 2017 15:13:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 05B1F160BA6 for ; Sun, 23 Apr 2017 17:13:07 +0200 (CEST) Received: (qmail 37723 invoked by uid 500); 23 Apr 2017 15:13:07 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 37710 invoked by uid 99); 23 Apr 2017 15:13:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Apr 2017 15:13:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CAFA2C0E1F for ; Sun, 23 Apr 2017 15:13:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id AoDKIxx-4Sst for ; Sun, 23 Apr 2017 15:13:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5FBD65F397 for ; Sun, 23 Apr 2017 15:13:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 93859E0A6C for ; Sun, 23 Apr 2017 15:13:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 152F521B54 for ; Sun, 23 Apr 2017 15:13:04 +0000 (UTC) Date: Sun, 23 Apr 2017 15:13:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IO-499) FilenameUtils.directoryContains(String, String) gives false positive when two directories exist with equal prefixes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 23 Apr 2017 15:13:08 -0000 [ https://issues.apache.org/jira/browse/IO-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980428#comment-15980428 ] ASF GitHub Bot commented on IO-499: ----------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/commons-io/pull/20 > FilenameUtils.directoryContains(String, String) gives false positive when two directories exist with equal prefixes > ------------------------------------------------------------------------------------------------------------------- > > Key: IO-499 > URL: https://issues.apache.org/jira/browse/IO-499 > Project: Commons IO > Issue Type: Bug > Affects Versions: 2.4 > Reporter: Federico Bonelli > Priority: Minor > > In a folder layout as such: > {code} > /foo/a.txt > /foo2/b.txt > {code} > The result of invoking directoryContains is wrong: > {code} > FilenameUtils.directoryContains("/foo", "/foo2/b.txt"); // returns true > {code} > even if "/foo" and "/foo2/b.txt" are the canonical paths, they start with the same characters, and the current implementation of the method fails. > As workaround we are currently appending a path separator '/' to the first argument. > It is noteworthy that the current implementation of FileUtils.directoryContains() reveals this issue because it uses the File.getCanonicalPath() to obtain the String paths of "/foo" and "/foo2/b.txt". -- This message was sent by Atlassian JIRA (v6.3.15#6346)