commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1325) Increase test coverage of ToStringBuilder class to 100%
Date Sat, 29 Apr 2017 13:49:04 GMT

    [ https://issues.apache.org/jira/browse/LANG-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989883#comment-15989883
] 

ASF GitHub Bot commented on LANG-1325:
--------------------------------------

Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/265
  
    That looks good, thanks! The coveralls bot normally tells us here if the coverage increased
or decreased. However, looks like you have added tabs to your code, and that caused Travis
CI build bot to fail (click on Details on the link above for details):
    
    ```
    #https://travis-ci.org/apache/commons-lang/jobs/227134274
    
    INFO] There is 1 error reported by Checkstyle 6.11.2 with /home/travis/build/apache/commons-lang/checkstyle.xml
ruleset.
    
    [ERROR] src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java:[617,1]
(whitespace) FileTabCharacter: File contains tab characters (this is the first instance).
    
    [INFO] ------------------------------------------------------------------------
    
    [INFO] BUILD FAILURE
    
    [INFO] ------------------------------------------------------------------------
    
    [INFO] Total time: 01:00 min
    
    [INFO] Finished at: 2017-04-29T13:20:38+00:00
    
    [INFO] Final Memory: 39M/431M
    
    [INFO] ------------------------------------------------------------------------
    
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check
(default-cli) on project commons-lang3: You have 1 Checkstyle violation. -> [Help 1]
    ```
    
    If you remove tabs by spaces it should pass the build and we will see the coverage report
here.
    
    Thanks!
    Bruno


> Increase test coverage of ToStringBuilder class to 100%
> -------------------------------------------------------
>
>                 Key: LANG-1325
>                 URL: https://issues.apache.org/jira/browse/LANG-1325
>             Project: Commons Lang
>          Issue Type: Test
>            Reporter: Arshad Basha
>            Priority: Minor
>
> Adding test cases to test the following methods of ToStringBuilder, with this, the code
coverage stands at 100%.
> 1)  append(final String fieldName, final boolean[] array)
> 2) append(final String fieldName, final boolean[] array, final boolean fullDetail)
> 3) append(final String fieldName, final byte[] array)
> 4) append(final String fieldName, final byte[] array, final boolean fullDetail)
> 5) append(final String fieldName, final char[] array)
> 6) append(final String fieldName, final char[] array, final boolean fullDetail)
> 7) append(final String fieldName, final double[] array)
> 8) append(final String fieldName, final double[] array, final boolean fullDetail)
> 9) append(final String fieldName, final float[] array)
> 10) append(final String fieldName, final float[] array, final boolean fullDetail)
> 11) append(final String fieldName, final int[] array)
> 12) append(final String fieldName, final int[] array, final boolean fullDetail)
> 13) append(final String fieldName, final long[] array)
> 14) append(final String fieldName, final long[] array, final boolean fullDetail)
> 15) append(final String fieldName, final Object[] array)
> 16) append(final String fieldName, final Object[] array, final boolean fullDetail)
> 17) append(final String fieldName, final short[] array)
> 18) append(final String fieldName, final short[] array, final boolean fullDetail)
> 19) appendAsObjectToString(final Object srcObject)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message