commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-389) Inconsistent increment of 'loc' in ZipFile.BoundedInputStream
Date Sun, 23 Apr 2017 22:04:04 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980537#comment-15980537
] 

Sebb commented on COMPRESS-389:
-------------------------------

It looks like the read() method is never called at logical EOF, so it always reads at least
one byte.

> Inconsistent increment of 'loc' in ZipFile.BoundedInputStream
> -------------------------------------------------------------
>
>                 Key: COMPRESS-389
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-389
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>
> ZipFile.BoundedInputStream.read() always increments loc, even if no bytes are read.
> However ZipFile.BoundedInputStream.read(byte[] b, int off, int len) only increments the
field if some bytes were read.
> This looks wrong.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message