commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-531) make it more esay-to-use: org.apache.commons.io.FileUtils.listFiles(File, IOFileFilter, IOFileFilter)
Date Thu, 20 Apr 2017 09:38:04 GMT

    [ https://issues.apache.org/jira/browse/IO-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976375#comment-15976375
] 

Sebb commented on IO-531:
-------------------------

If I read you correctly, you want

{code}
FileUtils.listFiles(File, null, dirfilter)
{code}

to act as if you had coded

{code}
FileUtils.listFiles(File, TrueFileFilter.TRUE, dirfilter)
{code}

Is that correct?

I don't think that is a good idea, because null means the opposite - i.e. FalseFileFilter.FALSE
- for the directory filter parameter.
That would be confusing.

It also seems unnecessary, given that there is already a (singleton) object which can be used
(i.e. TrueFileFilter.TRUE).


> make it more esay-to-use: org.apache.commons.io.FileUtils.listFiles(File, IOFileFilter,
IOFileFilter)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: IO-531
>                 URL: https://issues.apache.org/jira/browse/IO-531
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.5
>            Reporter: Hao Liu
>         Attachments: Commons IOIO-531.pdf
>
>
> when I only want to filter the directories, it should be better to allow me to set the
second parameter to null or I have to implement the org.apache.commons.io.filefilter.IOFileFilter
interface with nothing functionally task to do.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message