commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-lang issue #265: LANG-1325: Increase test coverage of ToStringBuilde...
Date Sat, 29 Apr 2017 13:48:29 GMT
Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/265
  
    That looks good, thanks! The coveralls bot normally tells us here if the coverage increased
or decreased. However, looks like you have added tabs to your code, and that caused Travis
CI build bot to fail (click on Details on the link above for details):
    
    ```
    #https://travis-ci.org/apache/commons-lang/jobs/227134274
    
    INFO] There is 1 error reported by Checkstyle 6.11.2 with /home/travis/build/apache/commons-lang/checkstyle.xml
ruleset.
    
    [ERROR] src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java:[617,1]
(whitespace) FileTabCharacter: File contains tab characters (this is the first instance).
    
    [INFO] ------------------------------------------------------------------------
    
    [INFO] BUILD FAILURE
    
    [INFO] ------------------------------------------------------------------------
    
    [INFO] Total time: 01:00 min
    
    [INFO] Finished at: 2017-04-29T13:20:38+00:00
    
    [INFO] Final Memory: 39M/431M
    
    [INFO] ------------------------------------------------------------------------
    
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check
(default-cli) on project commons-lang3: You have 1 Checkstyle violation. -> [Help 1]
    ```
    
    If you remove tabs by spaces it should pass the build and we will see the coverage report
here.
    
    Thanks!
    Bruno


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message