commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PascalSchumacher <...@git.apache.org>
Subject [GitHub] commons-lang pull request #261: LANG-1317: Add findAnnotation and findMethod...
Date Thu, 20 Apr 2017 21:17:32 GMT
Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/261#discussion_r112563123
  
    --- Diff: src/main/java/org/apache/commons/lang3/ClassUtils.java ---
    @@ -457,6 +457,44 @@ public static String getAbbreviatedName(final String className, final
int len) {
         }
     
         /**
    +     * <p>Gets a combination of {@link #getAllSuperclasses}(Class)} and
    +     * {@link #getAllInterfaces}(Class)}, one from superclasses, one
    +     * from interfaces, and so on in a breadth first way.</p>
    +     *
    +     * @param cls  the class to look up, may be {@code null}
    +     * @return the {@code List} of superclasses in order going up from this one
    --- End diff --
    
    This should also mention Interfaces.
    
    Can you add a since tag to this method?
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message