Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 04B35200C43 for ; Sun, 26 Mar 2017 20:11:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 03577160B87; Sun, 26 Mar 2017 18:11:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4B694160B82 for ; Sun, 26 Mar 2017 20:11:45 +0200 (CEST) Received: (qmail 18836 invoked by uid 500); 26 Mar 2017 18:11:44 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 18825 invoked by uid 99); 26 Mar 2017 18:11:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Mar 2017 18:11:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 01DDF185CAB for ; Sun, 26 Mar 2017 18:11:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id SwDgC0RUdwjM for ; Sun, 26 Mar 2017 18:11:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3748B5FB48 for ; Sun, 26 Mar 2017 18:11:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F044AE0436 for ; Sun, 26 Mar 2017 18:11:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 82C4724062 for ; Sun, 26 Mar 2017 18:11:41 +0000 (UTC) Date: Sun, 26 Mar 2017 18:11:41 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CODEC-230) URLCodec.WWW_FORM_URL should be private MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 26 Mar 2017 18:11:46 -0000 Sebb created CODEC-230: -------------------------- Summary: URLCodec.WWW_FORM_URL should be private Key: CODEC-230 URL: https://issues.apache.org/jira/browse/CODEC-230 Project: Commons Codec Issue Type: Bug Affects Versions: 1.10 Reporter: Sebb URLCodec.WWW_FORM_URL is mutable and should be made private. Otherwise subclasses can change the array accidentally or deliberately. However this would change the API for sub-classes. A work-round would be to create a parallel private field and keep WWW_FORM_URL as a copy, but marked deprecated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)