Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 69D9B200C68 for ; Wed, 29 Mar 2017 07:48:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 687D9160B89; Wed, 29 Mar 2017 05:48:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AF90C160B9C for ; Wed, 29 Mar 2017 07:48:45 +0200 (CEST) Received: (qmail 93913 invoked by uid 500); 29 Mar 2017 05:48:44 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 93898 invoked by uid 99); 29 Mar 2017 05:48:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Mar 2017 05:48:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7412FC0304 for ; Wed, 29 Mar 2017 05:48:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xVEFWSF2mYc8 for ; Wed, 29 Mar 2017 05:48:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 48D3F5FBE5 for ; Wed, 29 Mar 2017 05:48:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 694EDE0A31 for ; Wed, 29 Mar 2017 05:48:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CFFD125CEF for ; Wed, 29 Mar 2017 05:48:41 +0000 (UTC) Date: Wed, 29 Mar 2017 05:48:41 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 29 Mar 2017 05:48:46 -0000 [ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946564#comment-15946564 ] ASF GitHub Bot commented on LANG-1317: -------------------------------------- Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 Thank you @Abrasha , I signed up with [coveralls.io](http://coveralls.io) and see that all of this PR's changes are covered with unit tests: [MethodUtils](https://coveralls.io/jobs/24310263/source_files/797094203#L845) , [ClassUtils](https://coveralls.io/jobs/24310263/source_files/797094115#L477). Also these files show enhancement in coverage at [COVERAGE CHANGED](https://coveralls.io/jobs/24310263) :thinking: > Add findAnnotation and findMethodsWithAnnotation to MethodUtils > --------------------------------------------------------------- > > Key: LANG-1317 > URL: https://issues.apache.org/jira/browse/LANG-1317 > Project: Commons Lang > Issue Type: Improvement > Components: lang.reflect.* > Reporter: Yasser Zamani > Labels: patch > > In order to fix WW-4744 , mainly, I am going to add two functionalities to MethodUtils: findAnnotation and findMethodsWithAnnotation. > findAnnotation will be an extension for Method.getAnnotation that also searches interfaces and super classes while caching results with no memory leak. > findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation that also supports non public methods, super class and interface methods, again, while caching results as above. > Generally, do you agree with these in a pull request? If so, I will be working on it :) -- This message was sent by Atlassian JIRA (v6.3.15#6346)