Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 561D2200C33 for ; Sat, 11 Mar 2017 15:59:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 54911160B7B; Sat, 11 Mar 2017 14:59:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9FE73160B5D for ; Sat, 11 Mar 2017 15:59:07 +0100 (CET) Received: (qmail 34553 invoked by uid 500); 11 Mar 2017 14:59:06 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 34541 invoked by uid 99); 11 Mar 2017 14:59:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Mar 2017 14:59:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 41D76C028C for ; Sat, 11 Mar 2017 14:59:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 61gLyWAMwzA1 for ; Sat, 11 Mar 2017 14:59:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 44CDE5F3F0 for ; Sat, 11 Mar 2017 14:59:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A017CE0045 for ; Sat, 11 Mar 2017 14:59:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5199E243A6 for ; Sat, 11 Mar 2017 14:59:04 +0000 (UTC) Date: Sat, 11 Mar 2017 14:59:04 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (NET-625) SubnetUtils - improve construction MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 11 Mar 2017 14:59:08 -0000 [ https://issues.apache.org/jira/browse/NET-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-625. ---------------------- Resolution: Fixed Fix Version/s: 3.7 URL: http://svn.apache.org/viewvc?rev=1786511&view=rev Log: NET-625 SubnetUtils - improve construction Also make most fields final Modified: commons/proper/net/trunk/src/changes/changes.xml commons/proper/net/trunk/src/main/java/org/apache/commons/net/util/SubnetUtils.java > SubnetUtils - improve construction > ---------------------------------- > > Key: NET-625 > URL: https://issues.apache.org/jira/browse/NET-625 > Project: Commons Net > Issue Type: Improvement > Affects Versions: 3.6 > Reporter: Sebb > Fix For: 3.7 > > > The constructors for CIDR format and (address, mask) format both use the same calculate() method. This assumes the input is in CIDR format, which means that the constructor which handles (address, mask) format has to convert the strings to binary and then recreate the CIDR format. > This is wasteful. -- This message was sent by Atlassian JIRA (v6.3.15#6346)