Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 90F5C200C39 for ; Thu, 2 Mar 2017 01:10:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8F9E2160B78; Thu, 2 Mar 2017 00:10:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D82C9160B70 for ; Thu, 2 Mar 2017 01:10:53 +0100 (CET) Received: (qmail 581 invoked by uid 500); 2 Mar 2017 00:10:53 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 570 invoked by uid 99); 2 Mar 2017 00:10:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 00:10:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 93057C0055 for ; Thu, 2 Mar 2017 00:10:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id p5W5RY1zxizl for ; Thu, 2 Mar 2017 00:10:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C2A415F254 for ; Thu, 2 Mar 2017 00:10:51 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 26989E0599 for ; Thu, 2 Mar 2017 00:10:47 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E309B2416C for ; Thu, 2 Mar 2017 00:10:45 +0000 (UTC) Date: Thu, 2 Mar 2017 00:10:45 +0000 (UTC) From: "Makoto Sakaguchi (JIRA)" To: issues@commons.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NET-619) SubnetUtils creates a binary netmask in a bad way MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 02 Mar 2017 00:10:54 -0000 [ https://issues.apache.org/jira/browse/NET-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891349#comment-15891349 ] Makoto Sakaguchi commented on NET-619: -------------------------------------- I added some comments to the suggestion. https://github.com/apache/commons-net/pull/6 > SubnetUtils creates a binary netmask in a bad way > ------------------------------------------------- > > Key: NET-619 > URL: https://issues.apache.org/jira/browse/NET-619 > Project: Commons Net > Issue Type: Improvement > Reporter: Makoto Sakaguchi > Priority: Minor > > SubnetUtils runs a for-loop to create a binary netmask. > However, the way has been difficult to understand the program. > I suggest to replace with a bit-shift, and it has been made a poll request on GitHub. -- This message was sent by Atlassian JIRA (v6.3.15#6346)