Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sun, 5 Mar 2017 09:25:33 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13028962.1482062489000.776.1488705933030@Atlassian.JIRA>
In-Reply-To: <JIRA.13028962.1482062489000@Atlassian.JIRA>
References: <JIRA.13028962.1482062489000@Atlassian.JIRA> <JIRA.13028962.1482062489049@jira-lw-us.apache.org>
Subject: [jira] [Commented] (LANG-1300) Clarify or improve behaviour of
 int-based methods in StringUtils
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 05 Mar 2017 09:25:39 -0000


    [ https://issues.apache.org/jira/browse/LANG-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896133#comment-15896133 ] 

ASF GitHub Bot commented on LANG-1300:
--------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/250
  
    
    [![Coverage Status](https://coveralls.io/builds/10437855/badge)](https://coveralls.io/builds/10437855)
    
    Coverage decreased (-0.08%) to 94.455% when pulling **cc70a8aa73b7a3da4ca08629c470baf60b7b89a2 on MarkDacek:LANG-1300** into **6597c196521af500feef7a02610727eafa7ec1dc on apache:master**.


> Clarify or improve behaviour of int-based methods in StringUtils
> ----------------------------------------------------------------
>
>                 Key: LANG-1300
>                 URL: https://issues.apache.org/jira/browse/LANG-1300
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.5
>            Reporter: Duncan Jones
>            Priority: Minor
>             Fix For: Discussion
>
>
> The following methods use an {{int}} to represent a search character:
> {code:java}
> boolean contains(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar)
> int indexOf(final CharSequence seq, final int searchChar, final int startPos)
> int lastIndexOf(final CharSequence seq, final int searchChar)
> int lastIndexOf(final CharSequence seq, final int searchChar, final int startPos)
> {code}
> When I see an {{int}} representing a character, I tend to assume the method can handle supplementary characters. However, the current behaviour of these methods depends upon whether the {{CharSequence}} is a {{String}} or not.
> {code:java}
> StringBuilder builder = new StringBuilder();
> builder.appendCodePoint(0x2070E);
> System.out.println(StringUtils.lastIndexOf(builder, 0x2070E)); // -1
> System.out.println(StringUtils.lastIndexOf(builder.toString(), 0x2070E)); // 0
> {code}
> The Javadoc for these methods are ambiguous on this point, stating:
> {quote}
> This method uses {{String.lastIndexOf(int)}} if possible.
> {quote}
> I think we should consider updating the {{CharSequenceUtils}} methods used by this class to convert all {{CharSequence}} parameters to strings, enabling full code point support. The docs could be updated to make this crystal clear.
> There is a question of whether this breaks backwards compatibility.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)