Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sun, 19 Mar 2017 13:25:42 +0000 (UTC)
From: "Pascal Schumacher (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <JIRA.13006450.1474453167000.59472.1489929942442@Atlassian.JIRA>
In-Reply-To: <JIRA.13006450.1474453167000@Atlassian.JIRA>
References: <JIRA.13006450.1474453167000@Atlassian.JIRA> <JIRA.13006450.1474453167301@jira-lw-us.apache.org>
Subject: [jira] [Reopened] (LANG-1269) Wrong name or result of
 StringUtils::getJaroWinklerDistance
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 19 Mar 2017 13:25:51 -0000


     [ https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pascal Schumacher reopened LANG-1269:
-------------------------------------

> Wrong name or result of StringUtils::getJaroWinklerDistance
> -----------------------------------------------------------
>
>                 Key: LANG-1269
>                 URL: https://issues.apache.org/jira/browse/LANG-1269
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 3.3, 3.4, 3.5
>            Reporter: Jan Martin Keil
>            Assignee: Pascal Schumacher
>            Priority: Minor
>             Fix For: 3.6
>
>
> The name of the method StringUtils::getJaroWinklerDistance is misleading.
> Currently for equal strings {{1}} is returned, for completely different strings {{0}} is returned. That is a measure of similarity, not of a distance. A distance must be {{0}} for equal strings. I read on the issues LANG-591 and LANG-944, that it was decided to have a similar name to StringUtils::getLevenshteinDistance, but that requires also the change of the methods result.
> Could you please (1) rename the method to StringUtils::getJaroWinklerSimilarity or (2) change the method to return {{1 - currentResult}}?
> First option has the disadvantage to lose the similar naming of the similar methods, second option implies the risk to unnoticed introduce bugs in depending code. So I think it is preferable to use the first option.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)