commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUMBERS-16) Set tolerances in ComplexTest to zero?
Date Fri, 31 Mar 2017 12:09:41 GMT

    [ https://issues.apache.org/jira/browse/NUMBERS-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950762#comment-15950762
] 

Gilles commented on NUMBERS-16:
-------------------------------

bq. Any reason not to set these tolerances to zero?

Assuming that the internal representation is comprised of the real and imaginary parts, I'd
answer "no".


> Set tolerances in ComplexTest to zero?
> --------------------------------------
>
>                 Key: NUMBERS-16
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-16
>             Project: Commons Numbers
>          Issue Type: Improvement
>            Reporter: Eric Barnhill
>            Priority: Minor
>
> Considering the following JUnit test:
>     public void testConstructor() {
>         Complex z = new Complex(3.0, 4.0);
>         Assert.assertEquals(3.0, z.getReal(), 1.0e-5);
>         Assert.assertEquals(4.0, z.getImaginary(), 1.0e-5);
>     }
> That tolerance seems pretty high to me -- I sure would not want to work with a method
that was not stabler than that, nor can I see a reason that the numbers would be exactly the
same to the last place.
> Any reason not to set these tolerances to zero?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message