commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Barnhill (JIRA)" <>
Subject [jira] [Created] (NUMBERS-16) Set tolerances in ComplexTest to zero?
Date Fri, 31 Mar 2017 11:58:41 GMT
Eric Barnhill created NUMBERS-16:

             Summary: Set tolerances in ComplexTest to zero?
                 Key: NUMBERS-16
             Project: Commons Numbers
          Issue Type: Improvement
            Reporter: Eric Barnhill
            Priority: Minor

Considering the following JUnit test:

    public void testConstructor() {
        Complex z = new Complex(3.0, 4.0);
        Assert.assertEquals(3.0, z.getReal(), 1.0e-5);
        Assert.assertEquals(4.0, z.getImaginary(), 1.0e-5);

That tolerance seems pretty high to me -- I sure would not want to work with a method that
was not stabler than that, nor can I see a reason that the numbers would be exactly the same
to the last place.

Any reason not to set these tolerances to zero?

This message was sent by Atlassian JIRA

View raw message