commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CODEC-230) URLCodec.WWW_FORM_URL should be private
Date Sun, 26 Mar 2017 18:36:42 GMT

     [ https://issues.apache.org/jira/browse/CODEC-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved CODEC-230.
------------------------
       Resolution: Fixed
    Fix Version/s: 1.11

URL: http://svn.apache.org/viewvc?rev=1788761&view=rev
Log:
CODEC-230 URLCodec.WWW_FORM_URL should be private

Modified:
    commons/proper/codec/trunk/src/changes/changes.xml
    commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/net/URLCodec.java


> URLCodec.WWW_FORM_URL should be private
> ---------------------------------------
>
>                 Key: CODEC-230
>                 URL: https://issues.apache.org/jira/browse/CODEC-230
>             Project: Commons Codec
>          Issue Type: Bug
>    Affects Versions: 1.10
>            Reporter: Sebb
>             Fix For: 1.11
>
>
> URLCodec.WWW_FORM_URL is mutable and should be made private.
> Otherwise subclasses can change the array accidentally or deliberately.
> However this would change the API for sub-classes.
> A work-round would be to create a parallel private field and keep WWW_FORM_URL as a copy,
but marked deprecated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message