commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils
Date Sat, 25 Mar 2017 21:26:41 GMT

    [ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941979#comment-15941979
] 

ASF GitHub Bot commented on LANG-1317:
--------------------------------------

GitHub user yasserzamani opened a pull request:

    https://github.com/apache/commons-lang/pull/261

    LANG-1317: Add findAnnotation and findMethodsWithAnnotation

    In order to fix [WW-4744](https://issues.apache.org/jira/browse/WW-4744) ,
    
    findAnnotation will be an extension for Method.getAnnotation that also searches interfaces
and super classes.
    
    findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation that also
supports non public methods, super class and interface methods.
    
    NOTES:
    To keep changes simple, currently no cache provided. Let's do that when needed 😃 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yasserzamani/commons-lang LANG-1317

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #261
    
----
commit 74241a7cd79f2dda723f07948c7925f9b6511989
Author: Yasser Zamani <yasser.zamani@live.com>
Date:   2017-03-25T21:19:46Z

    LANG-1317: Add findAnnotation and findMethodsWithAnnotation to MethodUtils

----


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---------------------------------------------------------------
>
>                 Key: LANG-1317
>                 URL: https://issues.apache.org/jira/browse/LANG-1317
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: Yasser Zamani
>              Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to MethodUtils:
findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also searches interfaces
and super classes while caching results with no memory leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation that also
supports non public methods, super class and interface methods, again, while caching results
as above.
> Generally, do you agree with these in a pull request? If so, I will be working on it
:) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message