commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo
Date Fri, 24 Mar 2017 00:53:41 GMT

    [ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939504#comment-15939504
] 

Sebb commented on NET-630:
--------------------------

If the public API has not changed, there should be no need to edit examples.

Generally there should be no need to edit test cases either.
The only possible exceptions would be test cases that exercise internal code, i.e. classes
that are clearly marked as internal or package-protected methods.

If any other changes are needed to existing test or sample code, then the API is not compatible.

Obviously test cases can be extended to test new code, but existing tests must continue to
work without change.

> NET-630 Changed SubnetUtils for NEW SubnetInfo
> ----------------------------------------------
>
>                 Key: NET-630
>                 URL: https://issues.apache.org/jira/browse/NET-630
>             Project: Commons Net
>          Issue Type: Sub-task
>            Reporter: Makoto Sakaguchi
>
> The constructors of this class has been modified to create a object of subnet summary
information.
> Also, added two new static methods to create the object.
> Change log
> * The method rangeCheck, pop, and format of SubnetUtils was moved to the NEW SubnetInfo
class.
> Improved comments
> * Improved comments
> * Removed the insignificant value representation, which are no reasons to be defined
in this class.
> * *Renamed getAddressCount() to getAddressCountString()*
> ** The old name, getAddressCount(), was the obsoleted name and confused others.
> * Removed the NEW SubnetUtils class
> https://github.com/apache/commons-net/pull/23



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message