commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Makoto Sakaguchi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (NET-622) SubnetInfo#getCidrSignature - improve functions
Date Sat, 04 Mar 2017 10:03:45 GMT

     [ https://issues.apache.org/jira/browse/NET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Makoto Sakaguchi updated NET-622:
---------------------------------
    Description: 
The processing part of "netmask" is converted an integer to a string to an integer.
{code}
// a binary mask address
int netmask = 0b11111111000000000000000000000000;

// convert to a dotted decimal address
String maskStr = format(toArray(netmask));

// counting the 1-bit population
int cidr = pop(toInteger(maskStr)); // cidr: 8
{code}

So, I suggest to create CIDR from the netmask variable.
https://github.com/apache/commons-net/pull/9


  was:
The processing part of "netmask" is converted an integer to a string to an integer.
{code}
// a binary mask address
int netmask = 0b11110000000000000000000000000000;

// convert to a dotted decimal address
String maskStr = format(toArray(netmask));

// counting the 1-bit population
int cidr = pop(toInteger(maskStr));
{code}

So, I suggest to create CIDR from the netmask variable.
https://github.com/apache/commons-net/pull/9



> SubnetInfo#getCidrSignature - improve functions
> -----------------------------------------------
>
>                 Key: NET-622
>                 URL: https://issues.apache.org/jira/browse/NET-622
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Makoto Sakaguchi
>            Priority: Minor
>
> The processing part of "netmask" is converted an integer to a string to an integer.
> {code}
> // a binary mask address
> int netmask = 0b11111111000000000000000000000000;
> // convert to a dotted decimal address
> String maskStr = format(toArray(netmask));
> // counting the 1-bit population
> int cidr = pop(toInteger(maskStr)); // cidr: 8
> {code}
> So, I suggest to create CIDR from the netmask variable.
> https://github.com/apache/commons-net/pull/9



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message