commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NET-621) SubnetUtils#SubnetInfo - remove unnecessary accessors
Date Fri, 03 Mar 2017 17:08:45 GMT

    [ https://issues.apache.org/jira/browse/NET-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894717#comment-15894717
] 

Sebb commented on NET-621:
--------------------------

They do work, and they are currently used.

However I agree that they are not really necessary.

> SubnetUtils#SubnetInfo - remove unnecessary accessors
> -----------------------------------------------------
>
>                 Key: NET-621
>                 URL: https://issues.apache.org/jira/browse/NET-621
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Makoto Sakaguchi
>            Priority: Minor
>
> The below methods do not actually work.
> - private int netmask()       \{ return netmask; \}
> - private int network()       \{ return network; \}
> - private int address()       \{ return address; \}
> - private int broadcast()     \{ return broadcast; \}
> So, I suggest to remove them.
> https://github.com/apache/commons-net/pull/8



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message